Fix "null" string literal in steps that no exception text#1170
Merged
timja merged 3 commits intojenkinsci:mainfrom Mar 4, 2026
Merged
Fix "null" string literal in steps that no exception text#1170timja merged 3 commits intojenkinsci:mainfrom
timja merged 3 commits intojenkinsci:mainfrom
Conversation
added 3 commits
March 3, 2026 14:47
- return an empty string when the step's exception text is null - return an empty array from RestClient getExceptionText if the response text is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1169
Calling
HttpResponses.text(null)will create a response with text containing the string literal"null".Instead, pass the empty string
""as the response text when the exception text isnull.On the client side, check if the response text is valid (not null and not empty) before using it. Otherwise, return an empty array for the exception text.
Testing done
Local testing along with the added unit tests.
Submitter checklist